Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add signup.cash to js dev tools #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

p0o
Copy link

@p0o p0o commented Oct 26, 2020

No description provided.

@netlify
Copy link

netlify bot commented Oct 26, 2020

Deploy preview for bch ready!

Built with commit 892cf92

https://deploy-preview-42--bch.netlify.app

@merc1er
Copy link
Member

merc1er commented Oct 26, 2020

The code in the PR looks good, but I haven't tried the package. It doesn't say what the package is for in the docs.

EDIT: it does explain in the following sections :)

@imaginaryusername what do you think about adding this tool?

@merc1er
Copy link
Member

merc1er commented Oct 26, 2020

I just tested wallet.signup.cash and it is not sending transactions. It seems to be powered by this tool, so I would recommend waiting for a more stable release before listing it.

Copy link
Member

@merc1er merc1er left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sending transactions is broken on https://wallet.signup.cash

@merc1er merc1er changed the title Add signup.cash to js dev tools WIP: Add signup.cash to js dev tools Oct 26, 2020
@p0o
Copy link
Author

p0o commented Oct 26, 2020

@merc1er May you try the example app for payment and let me know if it works? Thanks

https://signup-examples-v1.vercel.app/example_simple_tipping_button.html

@merc1er
Copy link
Member

merc1er commented Oct 26, 2020

@merc1er May you try the example app for payment and let me know if it works? Thanks

https://signup-examples-v1.vercel.app/example_simple_tipping_button.html

What is the expected behaviour? It seems to be working on my end:

Screenshot 2020-10-26 at 15 29 37

@p0o
Copy link
Author

p0o commented Oct 26, 2020

It's a tipping button so you should be able to do a transaction and see the txid link
Screen Shot 2020-10-26 at 4 33 02 PM

@p0o
Copy link
Author

p0o commented Oct 26, 2020

@merc1er The issue with the wallet should be fixed now. Would appreciate if you try again.

@merc1er
Copy link
Member

merc1er commented Oct 26, 2020

It seems to be working now, but once in a while i get this:

Screenshot 2020-10-26 at 22 53 44

Actually it redirects me to this URL: https://wallet.signup.cash/send which returns a 404

@p0o
Copy link
Author

p0o commented Oct 26, 2020

@merc1er I think you were reloading the page on different paths. But good catch, forgot to redirect 404 to index. Already fixed.

@netlify
Copy link

netlify bot commented Jun 22, 2021

A new user left a comment. This user must be approved by a Netlify team owner before comments can be displayed.

Approve this user

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants