Repository navigation
build: include test suite in sdist package (#114) - #116
Open
chiragjangiir wants to merge 1 commit into
Open
chiragjangiir wants to merge 1 commit into
chiragjangiir wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #114
Problem
As reported in #114, the
test/directory and its fixtures were missing from the published PyPI source distribution (sdist), causingpytestruns directly from the sdist tarball (e.g., in downstream package maintainer pipelines) to collect 0 items and fail.Solution
Configured poetry's
includetable inpyproject.tomlto packagetestinto sdist distributions:Verification
python3 -m build --sdist:tar -tzf dist/mediafile-*.tar.gzthattest/__init__.py,test/_common.py, and alltest/rsrc/*media fixtures are present.python3 -m build --wheel:unzip -l dist/*.whlthat the binary wheel remains lean and contains onlymediafilepackage code, license, and metadata without test bloat.