[DEV-24810] uses URL api instead of string interpolation #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously URLs that already had parameters would have two question marks "?"
liesas
approved these changes
Dec 5, 2024
iz-podpolja
requested changes
Dec 5, 2024
src/helpers/sharing_helper.ts
Outdated
| @@ -9,6 +9,14 @@ export const toQuery = (object: Record<string, any>) => { | |||
| return searchParams ? `?${searchParams}` : '' | |||
| } | |||
|
|
|||
| export const addParamsToUrl = (oldUrl: string, params: Record<string, any>) => { | |||
| const newUrl = new URL(oldUrl) | |||
| for (const [key, value] of params.entries()) { | |||
There was a problem hiding this comment.
If this is actually Record<string, any> then hashes do not posses methods, you should use Object.entries(params), if this is actually URLSearchParams then please type the argument as such
There was a problem hiding this comment.
I'm following what comes from this:
export type BaseShareActionArgs = { shareUrl: string; utmParams?: Record<string, any>; teaser?: string }I changed the entries call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEV-24810
uses URL api instead of string interpolation
Previously URLs that already had parameters
would have two question marks "?"
I'll publish after merging and add it to the main project.