fix symbolic links and remove deprecated rmdir(...) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evoludolab
changed the title
* update version to 1.5.4 * add debug config for EvoLudo
* 0.28.0-alpha.21 fails to compile (macOS Sonoma, Silicon M2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for keeping gitexporter alive!
I just noticed that gitexporter chokes on repo's that include symbolic links. If the destination of the link changes in later commits I see no reason that it couldn't be safely overridden.
This PR does just that and, as an aside, it also removes the now deprecated call to
fs.rmdir(...)and replaced it byfs.rm(...).