Refactored LinksForm.jsx component to improve performance and avoid unnecessary API calls #5891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also needs to be rebased please |
rautniraj
force-pushed
the
fixes-to-LinksForm.jsx-component
branch
from
fe9f93e to
6a5ac4d
Compare
…n button click. We can extend the performance optimization by preventing unnecessary onSubmit of Form in case of tnc, privacy policy and help center fields. So PATCH request will only be sent if there is actual change in the value. I have introduced a useRef variable formText which initially stores the actual value of these fields and further tracks any changes to the value. In handleSubmit function we call mutation only when this formText variable shows any changes. Hence this way we prevent any unnecessary PATCH request when user continuously clicks the Change URL function.
rautniraj
force-pushed
the
fixes-to-LinksForm.jsx-component
branch
from
6a5ac4d to
3b3c9ee
Compare
|
Rebased and updated my commit message to include details for the changes done in code @farhatahmad |
|
Needs to be updated again please |
|
|
Updated @farhatahmad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In continuation to my PR #5887, as discussed in my Seventh Improvement point, we can extend the performance optimization by preventing unnecessary onSubmit of Form in case of tnc, privacy policy and help center fields. So PATCH request will only be sent if there is actual change in the value.
I have introduced a useRef variable formText which initially stores the actual value of these fields and further tracks any changes to the value.
In handleSubmit function we call mutation only when this formText variable shows any changes. Hence this way we prevent any unnecessary PATCH request when user continuously clicks the Change URL function.