Greenlight version number only appears for admins #5893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alihadimazeh
commented
Jul 24, 2024
•
alihadimazeh
commented
- Changes to App.jsx: passed in currentUser to the Footer
- Footer renders the version number if the current user is an admin
- resolves [V3] Feature: Hide Greenlight Version Number #5884
farhatahmad
reviewed
Jul 25, 2024
| import useEnv from '../../hooks/queries/env/useEnv'; | ||
| import useSiteSetting from '../../hooks/queries/site_settings/useSiteSetting'; | ||
|
|
||
| export default function Footer() { | ||
| export default function Footer({ currentUser = null }) { |
There was a problem hiding this comment.
You don't need to get currentUser through props. Props are only needed if you need to track their state across multiple components. In this case, we can just get current user directly in the Footer component
- Changes to App.jsx: passed in currentUser to the Footer - Footer renders the version number if the current user is an admin
Footer component imports useAuth to get the current user
alihadimazeh
force-pushed
the
5884_hide_version_number
branch
from
02deb02 to
0506021
Compare
|
farhatahmad
approved these changes
Jul 25, 2024
|
Hmm, why not make this a setting instead with a default of hidden? - We use this to see which instances we still need to update... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.