5815 signup specific domains #5916
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added a row for the specific email domain sign up - added corresponding locales
- added specific email domain sign up to site settings in `tenant.rb`
- added the setting SpecificEmailDomainSignUp
farhatahmad
reviewed
Aug 12, 2024
|
I think the only thing i would change here is the wording "Specific Email Domain Sign Up" is very wordy. I would just use "Allowed Domains" or something simple like that. That'll require a few changes, including the Setting name itself |
- changed all instances of previous name to AllowedDomains
farhatahmad
reviewed
Aug 13, 2024
| @@ -319,7 +319,10 @@ | |||
| "open": "Open Registration", | |||
| "invite": "Join by Invitation", | |||
| "approval": "Approve/Decline" | |||
| } | |||
| }, | |||
| "allowed_domains": "Allow Specific Email Domains", | |||
There was a problem hiding this comment.
I would just put this as "Allowed Email Domains"
| @@ -420,7 +423,8 @@ | |||
| "privacy_policy_updated": "The privacy notice has been updated.", | |||
| "helpcenter_updated": "The help center link has been updated.", | |||
| "terms_of_service_updated": "The terms of service have been updated.", | |||
| "maintenance_updated": "The maintenance banner has been updated." | |||
| "maintenance_updated": "The maintenance banner has been updated.", | |||
| "allowed_domains_signup_updated": "The specific email domain sign up has been updated" | |||
There was a problem hiding this comment.
"The allowed email domains has been updated"
db/data/20240806205559_add_domain_specific_email_signup_to_site_settings.rb
Outdated
Show resolved
Hide resolved
db/schema.rb
Outdated
| t.string "session_token" | ||
| t.datetime "session_expiry", precision: nil | ||
| t.datetime "session_expiry" | ||
| t.integer "status", default: 0 | ||
| t.index ["email", "provider"], name: "index_users_on_email_and_provider", unique: true | ||
| t.index ["reset_digest"], name: "index_users_on_reset_digest", unique: true |
There was a problem hiding this comment.
This shouldn't be included
There was a problem hiding this comment.
the change should not be included, or the file itself?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5815