Skip to content

Commit

Permalink
fix(docs): prevent missing fa icons on PDF export
Browse files Browse the repository at this point in the history
Using the example `puppeter` command from the README, some times the FontAwesome icons were missing from exported PDF.

Thanks [bn3t](https://github.com/bn3t) for the [solution](#4 (comment))
  • Loading branch information
biosan authored Feb 20, 2021
1 parent 4ee835f commit 808dd71
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ I use Puppeteer-CLI to make a PDF from my HTML resume.

```
npm install -g puppeteer-cli
puppeteer --margin-top 0 --margin-right 0 --margin-bottom 0 --margin-left 0 --format A4 print resume.html resume.pdf
puppeteer --wait-until networkidle0 --margin-top 0 --margin-right 0 --margin-bottom 0 --margin-left 0 --format A4 print resume.html resume.pdf
```

Obviously you could write a very simple Node script to use the real Puppeteer and the `render` function to make a PDF without first exporting the HTML version.
Expand Down

0 comments on commit 808dd71

Please sign in to comment.