Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use name instead of company per spec #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stephenyeargin
Copy link

Prior to this PR, the Handlebars template referred to work[].company instead of work[].name, which would cause files adhering to the schema to render a blank header for each work position. This PR corrects the reference.

Before

before

After

after

@stephenyeargin stephenyeargin force-pushed the fix-missing-work-name branch 2 times, most recently from b39c247 to 99facb0 Compare April 30, 2024 05:27
@stephenyeargin stephenyeargin force-pushed the fix-missing-work-name branch from 99facb0 to c08d74f Compare May 26, 2024 18:38
@stephenyeargin stephenyeargin force-pushed the fix-missing-work-name branch from c08d74f to 05d07a8 Compare May 26, 2024 19:40
@giodamelio
Copy link

Thanks for this patch @stephenyeargin. I can attest that it works great.

@biosan is it possible to get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants