Repository navigation
bip375: sync vendored DLEQ code with BIP-374 - #2304
Merged
Merged
Conversation
bip-0375/deps/dleq.py is adapted from the BIP-374 reference code but predates the change that treats the challenge e as a scalar (bitcoin#2262). Reduce the challenge hash mod n and reject proofs with e >= n, so the copy used by the BIP-375 validator matches the current BIP-374 reference.
jonatack
reviewed
Sep 25, 2026
Member
Done in #2309. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bip-0375/deps/dleq.pyis a copy of the BIP-374 reference code, used by the BIP-375 validator to checkPSBT_GLOBAL_SP_DLEQ/PSBT_IN_SP_DLEQproofs. It was taken before #2262, so it still uses the raw challenge hash aseand doesn't reject proofs withe >= n.This applies the same two changes to the copy. After this the functions match
bip-0374/reference.pyline for line (apart from the unit tests). A challenge hash >= n has negligible probability, so nothing changes in practice:test_runner.pystill passes all 42 vectors, and the 17 BIP-374 verify vectors give the same results before and after. It just keeps the copy from drifting from the spec.