Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix V2 Rest book API return funding result error #205

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fshiori
Copy link
Contributor

@fshiori fshiori commented Dec 24, 2019

Description:

rest book api return different sort by trading and funding,
and now the SDK only support trading.

Breaking changes:

None

New features:

None

Fixes:

  • NewBookUpdateFromRaw func data comment error
  • process funding symbol corerectly

PR status:

  • Version bumped
  • Change-log updated

@harry830622
Copy link

@fshiori Really appreciate the PR, bump into the exact same problem here.
@JacobPlaster Would you please take a look and merge the PR? Or how can I help to merge this PR?
Thanks

@@ -1580,9 +1581,14 @@ func IsRawBook(precision string) bool {
return precision == "R0"
}

func IsFunding(symbol string) bool {
return strings.HasPrefix(symbol, "f")
Copy link

@harry830622 harry830622 Aug 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return strings.HasPrefix(symbol, "f")
return strings.HasPrefix(symbol, FundingPrefix)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants