Repository navigation
Conversation
Signed-off-by: AC <ac@fabtek.cn>
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can copy the agent prompt from any finding and feed it to your IDE agent Powered by Qodo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetIndex(-1)panics on an array, including an empty array, while an out-of-range positive index returns a chainable null Json value.Check the lower bound as well as the upper bound before indexing the slice. Tests cover -1, the minimum/maximum int, an out-of-range positive index, empty/populated arrays, null/object values, valid endpoints, and chaining through a missing index.
The regression panics on the original base.
go test -race ./...,go vet ./..., gofmt andgit diff --checkpass (Go 1.27.1, Linux arm64).All-state issue/PR searches for GetIndex, negative and index found no matching fix. #22 concerns Must* variadic defaults, #41 a nil receiver, and open #96/#97 nested Json values/trailing input, all separate behaviors. No API or dependency change.
AI assistance: prepared and tested with Codex.