fix type and update rectNotZero function

bitwarden · Jan 13, 2025 · a3ce34c · a3ce34c
1 parent e878578
commit a3ce34c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/apps/browser/src/autofill/background/overlay.background.ts b/apps/browser/src/autofill/background/overlay.background.ts
@@ -70,7 +70,7 @@ import {
   generateDomainMatchPatterns,
   generateRandomChars,
   isInvalidResponseStatusCode,
-  rectNotZero,
+  rectHasSize,
   specialCharacterToKeyMap,
 } from "../utils";
 
@@ -1402,10 +1402,10 @@ export class OverlayBackground implements OverlayBackgroundInterface {
     }
     // Calculate the smallest left and largest right values to determine width
     const left = Math.min(
-      ...filteredObjects.filter((obj) => rectNotZero(obj.rect)).map((obj) => obj.rect.left),
+      ...filteredObjects.filter((obj) => rectHasSize(obj.rect)).map((obj) => obj.rect.left),
     );
     const largestRight = Math.max(
-      ...filteredObjects.filter((obj) => rectNotZero(obj.rect)).map((obj) => obj.rect.right),
+      ...filteredObjects.filter((obj) => rectHasSize(obj.rect)).map((obj) => obj.rect.right),
     );
 
     const width = largestRight - left;

diff --git a/apps/browser/src/autofill/services/autofill-overlay-content.service.ts b/apps/browser/src/autofill/services/autofill-overlay-content.service.ts
@@ -971,7 +971,7 @@ export class AutofillOverlayContentService implements AutofillOverlayContentServ
     });
   }
 
-  /**his.formFieldElements
+  /**
    * Gets the bounding client rects for the most recently focused field. This method will
    * attempt to use an intersection observer to get the most recently focused field's
    * bounding client rects. If the intersection observer is not supported, or the