-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-12989] Create process for qa to build client with particular sdk version #11601
Merged
coroiu
merged 45 commits into
main
from
PM-12989-create-process-for-qa-to-build-client-with-particular-sdk-version
Nov 19, 2024
Merged
Changes from 42 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
657d2f2
feat: update sdk service abstraction with documentation and new `userโฆ
coroiu e332670
feat: add uninitialized user client with cache
coroiu f7f79ba
feat: initialize user crypto
coroiu f4a589f
feat: initialize org keys
coroiu d7e82fc
fix: org crypto not initializing properly
coroiu cc8302a
feat: avoid creating clients unnecessarily
coroiu 421f372
chore: remove dev print/subscription
coroiu f95cfe5
fix: clean up cache
coroiu 8e0ef47
chore: update sdk version
coroiu 7e7a10a
feat: implement clean-up logic (#11504)
coroiu 1ed18e5
chore: bump sdk version to fix build issues
coroiu e8a1049
chore: bump sdk version to fix build issues
coroiu b9a729b
fix: missing constructor parameters
coroiu ac89518
refactor: simplify free() and delete() calls
coroiu 3adc18e
refactor: use a named function for client creation
coroiu 6b7b016
fix: client never freeing after refactor
coroiu 85d4809
fix: broken impl and race condition in tests
coroiu 276da3e
feat: add sdk override to desktop build
coroiu 5e1647c
feat: add SDK version to browser about dialog
coroiu 4045cd8
feat: add sdk override to browser build
coroiu f5af7df
fix: `npm ci` overriding the override
coroiu c0175b4
fix: artifacts not properly downloaded
coroiu f3895a8
fix: switch to new repository
coroiu dfa70f9
feat: add debug version function to web
coroiu 3eb5298
feat: add sdk-version to CLI
coroiu 020e4c6
feat: add version to desktop
coroiu 79d61c9
feat: add override to cli
coroiu 091b95f
feat: add override to web
coroiu cf565bb
fix: cli version acting as default command
coroiu f5f2cb8
fix: consistent workflow input name
coroiu 5286644
feat: add error handling
coroiu b6da518
feat: upgrade sdk-internal
coroiu 2ef1fb1
Merge branch 'main' into PM-12989-create-process-for-qa-to-build-clieโฆ
coroiu 9c8d841
fix: forgot to update package lock
coroiu 858b495
Merge branch 'main' into PM-12989-create-process-for-qa-to-build-clieโฆ
coroiu 1f3ed1f
fix: broken CI build
coroiu 32e038c
chore: revert version changes
coroiu f75f71f
refactor: move error handling code
coroiu f0319f9
chore: bump SDK to 0.2.0.main-1
coroiu 8a9ef07
fix: clean up references to inputs.sdk_commit
coroiu da703f3
refactor: rename `init` to `applyVersionToWindow`
coroiu 610697c
Merge branch 'main' into PM-12989-create-process-for-qa-to-build-clieโฆ
coroiu 5f4d6ec
Merge branch 'main' into PM-12989-create-process-for-qa-to-build-clieโฆ
coroiu f241b15
Merge branch 'main' into PM-12989-create-process-for-qa-to-build-clieโฆ
coroiu 2d1c698
Merge branch 'main' into PM-12989-create-process-for-qa-to-build-clieโฆ
coroiu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
โ๏ธ The label also requires localization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we translate
SDK
, see e.g. "Electron", "Rendered"clients/apps/desktop/src/main/menu/menu.about.ts
Lines 57 to 65 in c886217
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks like code we haven't transitioned yet. Of the 4 labels, only 1 (Node) is a brand name. The others are just words. That said, this isn't my call. I was nitting a code smell.
@danielleflinn - Should we be localizing the SDK label? Should I add a ticket to localize the snippet @coroiu just posted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some context, I don't really expect users to be looking at this, if anything they might copy and paste it when contacting CS. This is just a way to confirm that QA is testing with the correct version