Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13848] (Marketing) Update testimonial in free registration page #11603

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

mark-youssef-bitwarden
Copy link
Collaborator

🎟️ Tracking

Asana:

📔 Objective

Update the company testimonial on the bottom left.

📸 Screenshots

Screenshot 2024-10-16 at 11 18 27 AM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 33.24%. Comparing base (e53bd45) to head (8e45d4a).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...tion/content/logo-company-testimonial.component.ts 0.00% 2 Missing ⚠️
...p/auth/trial-initiation/trial-initiation.module.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11603      +/-   ##
==========================================
+ Coverage   33.20%   33.24%   +0.03%     
==========================================
  Files        2782     2783       +1     
  Lines       86484    86529      +45     
  Branches    16484    16488       +4     
==========================================
+ Hits        28721    28766      +45     
+ Misses      55476    55473       -3     
- Partials     2287     2290       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Oct 17, 2024

Logo
Checkmarx One – Scan Summary & Details83bd5c81-6920-4421-818b-1fc237f1c71c

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 82 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 515 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 187 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /publish-desktop.yml: 196 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /publish-cli.yml: 181 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-browser.yml: 367 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 405 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 247 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 180 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /staged-rollout-desktop.yml: 29 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /crowdin-pull.yml: 41 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-web.yml: 342 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-web.yml: 191 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /retrieve-current-desktop-rollout.yml: 23 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1293 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /publish-web.yml: 44 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /crowdin-pull.yml: 35 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-browser.yml: 408 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 523 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 194 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /brew-bump-desktop.yml: 26 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-web.yml: 297 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1339 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /publish-desktop.yml: 122 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 162 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 288 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 891 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /publish-cli.yml: 141 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 297 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 201 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 499 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-auto-bump.yml: 21 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /publish-cli.yml: 104 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 359 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 507 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 48 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /publish-desktop.yml: 245 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-web.yml: 267 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /version-bump.yml: 515 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /version-bump.yml: 523 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /version-bump.yml: 82 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /version-bump.yml: 247 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /publish-desktop.yml: 122 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /publish-cli.yml: 104 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /version-bump.yml: 187 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /publish-desktop.yml: 196 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /version-bump.yml: 180 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1293 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /version-bump.yml: 48 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /version-bump.yml: 201 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /retrieve-current-desktop-rollout.yml: 23 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1339 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-browser.yml: 408 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /version-bump.yml: 499 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /publish-cli.yml: 181 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-browser.yml: 367 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /publish-cli.yml: 141 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-cli.yml: 405 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 288 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /version-bump.yml: 162 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /version-bump.yml: 194 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /version-bump.yml: 507 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /publish-desktop.yml: 245 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /version-bump.yml: 359 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /version-bump.yml: 297 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /publish-web.yml: 44 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 891 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /build-web.yml: 296
MEDIUM Unpinned Actions Full Length Commit SHA /publish-cli.yml: 180
MEDIUM Unpinned Actions Full Length Commit SHA /build-web.yml: 266
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 890
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 179
MEDIUM Unpinned Actions Full Length Commit SHA /build-browser.yml: 407
MEDIUM Unpinned Actions Full Length Commit SHA /version-auto-bump.yml: 20
MEDIUM Unpinned Actions Full Length Commit SHA /publish-cli.yml: 140
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 498
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 522
MEDIUM Unpinned Actions Full Length Commit SHA /publish-desktop.yml: 195
MEDIUM Unpinned Actions Full Length Commit SHA /publish-desktop.yml: 244
MEDIUM Unpinned Actions Full Length Commit SHA /staged-rollout-desktop.yml: 28
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 193
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 186
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 358
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 287
MEDIUM Unpinned Actions Full Length Commit SHA /build-browser.yml: 366
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 200
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 246
MEDIUM Unpinned Actions Full Length Commit SHA /crowdin-pull.yml: 34
MEDIUM Unpinned Actions Full Length Commit SHA /publish-web.yml: 43
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 514
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1292
MEDIUM Unpinned Actions Full Length Commit SHA /publish-desktop.yml: 121
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 404
MEDIUM Unpinned Actions Full Length Commit SHA /crowdin-pull.yml: 40
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 506
MEDIUM Unpinned Actions Full Length Commit SHA /build-web.yml: 190
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 81
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 296
MEDIUM Unpinned Actions Full Length Commit SHA /publish-cli.yml: 103
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1338
MEDIUM Unpinned Actions Full Length Commit SHA /build-web.yml: 341
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 161
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 47
MEDIUM Unpinned Actions Full Length Commit SHA /brew-bump-desktop.yml: 25
MEDIUM Unpinned Actions Full Length Commit SHA /retrieve-current-desktop-rollout.yml: 22
LOW Unpinned Actions Full Length Commit SHA /version-bump.yml: 514
LOW Unpinned Actions Full Length Commit SHA /build-web.yml: 296
LOW Unpinned Actions Full Length Commit SHA /crowdin-pull.yml: 40
LOW Unpinned Actions Full Length Commit SHA /build-web.yml: 266
LOW Unpinned Actions Full Length Commit SHA /publish-desktop.yml: 244
LOW Unpinned Actions Full Length Commit SHA /version-bump.yml: 179
LOW Unpinned Actions Full Length Commit SHA /version-bump.yml: 81
LOW Unpinned Actions Full Length Commit SHA /publish-cli.yml: 103
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1292
LOW Unpinned Actions Full Length Commit SHA /build-web.yml: 190
LOW Unpinned Actions Full Length Commit SHA /retrieve-current-desktop-rollout.yml: 22
LOW Unpinned Actions Full Length Commit SHA /version-bump.yml: 296
LOW Unpinned Actions Full Length Commit SHA /build-browser.yml: 366
LOW Unpinned Actions Full Length Commit SHA /publish-web.yml: 43
LOW Unpinned Actions Full Length Commit SHA /version-bump.yml: 161
LOW Unpinned Actions Full Length Commit SHA /build-web.yml: 341
LOW Unpinned Actions Full Length Commit SHA /staged-rollout-desktop.yml: 28
LOW Unpinned Actions Full Length Commit SHA /version-bump.yml: 506
LOW Unpinned Actions Full Length Commit SHA /brew-bump-desktop.yml: 25
LOW Unpinned Actions Full Length Commit SHA /version-bump.yml: 47
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1338
LOW Unpinned Actions Full Length Commit SHA /version-bump.yml: 186
LOW Unpinned Actions Full Length Commit SHA /version-bump.yml: 358
LOW Unpinned Actions Full Length Commit SHA /build-cli.yml: 404
LOW Unpinned Actions Full Length Commit SHA /publish-cli.yml: 140
LOW Unpinned Actions Full Length Commit SHA /build-browser.yml: 407
LOW Unpinned Actions Full Length Commit SHA /publish-desktop.yml: 121
LOW Unpinned Actions Full Length Commit SHA /version-bump.yml: 498
LOW Unpinned Actions Full Length Commit SHA /version-auto-bump.yml: 20
LOW Unpinned Actions Full Length Commit SHA /version-bump.yml: 200
LOW Unpinned Actions Full Length Commit SHA /version-bump.yml: 522
LOW Unpinned Actions Full Length Commit SHA /publish-cli.yml: 180
LOW Unpinned Actions Full Length Commit SHA /publish-desktop.yml: 195
LOW Unpinned Actions Full Length Commit SHA /version-bump.yml: 246
LOW Unpinned Actions Full Length Commit SHA /crowdin-pull.yml: 34
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 890
LOW Unpinned Actions Full Length Commit SHA /version-bump.yml: 193
LOW Use_of_Broken_or_Risky_Cryptographic_Algorithm /libs/common/src/platform/services/sdk/default-sdk.service.ts: 172
LOW Use_of_Broken_or_Risky_Cryptographic_Algorithm /libs/common/src/platform/services/sdk/default-sdk.service.ts: 155

@mark-youssef-bitwarden mark-youssef-bitwarden force-pushed the marketing/free-registration-logo-update branch from bb9ef9b to f17e6ba Compare October 17, 2024 17:26
Copy link
Contributor

@rr-bw rr-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one small change.

@rr-bw rr-bw added the needs-qa Marks a PR as requiring QA approval label Oct 18, 2024
@mark-youssef-bitwarden mark-youssef-bitwarden merged commit 4768f7c into main Oct 18, 2024
24 of 25 checks passed
@mark-youssef-bitwarden mark-youssef-bitwarden deleted the marketing/free-registration-logo-update branch October 18, 2024 17:25
@rr-bw rr-bw changed the title [Marketing] Update testimonial in free registration page [PM-13848] (Marketing) Update testimonial in free registration page Oct 18, 2024
@rr-bw rr-bw removed the needs-qa Marks a PR as requiring QA approval label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants