[PM-13950] Do not do browser extension permission check if the Show autofill suggestions setting is being turned off

[jprusik]

🎟️ Tracking

PM-13950

📔 Objective

Do not do browser extension permission check if the Show autofill suggestions setting is being turned off

Screencap

Kapture.2024-11-06.at.17.15.17.mp4

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 33.61%. Comparing base (2c5221d) to head (36f4e05).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
.../src/autofill/popup/settings/autofill.component.ts	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11889      +/-   ##
==========================================
- Coverage   33.62%   33.61%   -0.01%     
==========================================
  Files        2823     2823              
  Lines       88180    88181       +1     
  Branches    16799    16800       +1     
==========================================
- Hits        29647    29640       -7     
- Misses      56211    56219       +8     
  Partials     2322     2322              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Checkmarx One – Scan Summary & Details – 80f88e0d-79b0-4ef8-876c-376fbf6068e9

New Issues

Severity	Issue	Source File / Package	Checkmarx Insight
	Client_JQuery_Deprecated_Symbols	/apps/cli/src/service-container/service-container.ts: 876	Attack Vector