Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14183] Show success toast on copy history value #11911

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

djsmith85
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14183

📔 Objective

Update styling of the copy success toast

  • Remove unnecessary copy icon - 53fbfc2
  • Fix styling of copy success toast - 478c313
    • Use CopyClick directive instead of manually copying and showing the toast
    • Adjust tests

📸 Screenshots

Before

image

After

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

- Use CopyClick directive instead of manually copying and showing the toast
- Adjust tests
@djsmith85 djsmith85 requested a review from a team as a code owner November 7, 2024 22:11
@djsmith85 djsmith85 enabled auto-merge (squash) November 7, 2024 22:12
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.58%. Comparing base (f206e0f) to head (478c313).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11911      +/-   ##
==========================================
- Coverage   33.59%   33.58%   -0.01%     
==========================================
  Files        2825     2829       +4     
  Lines       88289    88302      +13     
  Branches    16834    16831       -3     
==========================================
- Hits        29658    29654       -4     
- Misses      56308    56329      +21     
+ Partials     2323     2319       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@shane-melton shane-melton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for grabbing this!

@djsmith85 djsmith85 merged commit b23d62a into main Nov 7, 2024
69 of 71 checks passed
@djsmith85 djsmith85 deleted the vault/pm-14183/show-succes-on-history-copy branch November 7, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants