[PM-5718] Fix free organization generating TOTP

[shane-melton]

🎟️ Tracking

PM-5718

📔 Objective

The add-edit component in the individual vault would not have an organization set and would fall back to the user's premium status instead of the organization that owned the cipher, which would allow free org ciphers to generate totps codes.

Fixed by updating the showTotp condition to check only consider the user premium status if it is not owned by an organization; otherwise, rely on the value of organizationUseTotp flag on the cipher view.

Applies the same logic to the refreshed CipherView component as well.

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

Attention: Patch coverage is 30.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 34.14%. Comparing base (c1e3836) to head (c29c559).
Report is 29 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...ibs/angular/src/vault/components/view.component.ts	0.00%	5 Missing ⚠️
apps/desktop/src/app/app.component.ts	0.00%	4 Missing ⚠️
...in-credentials/login-credentials-view.component.ts	75.00%	2 Missing ⚠️
apps/desktop/src/vault/app/vault/view.component.ts	0.00%	1 Missing ⚠️
...c/app/vault/individual-vault/add-edit.component.ts	0.00%	0 Missing and 1 partial ⚠️
...angular/src/vault/components/add-edit.component.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #11918   +/-   ##
=======================================
  Coverage   34.13%   34.14%           
=======================================
  Files        2936     2936           
  Lines       90428    90446   +18     
  Branches    16988    16992    +4     
=======================================
+ Hits        30869    30880   +11     
- Misses      57102    57109    +7     
  Partials     2457     2457           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Checkmarx One – Scan Summary & Details – 06c5b365-8f5c-4485-b2e1-50380c5b7820

New Issues

Severity	Issue	Source File / Package	Checkmarx Insight
	Client_Privacy_Violation	/apps/cli/src/commands/get.command.ts: 162	Attack Vector
	Client_Privacy_Violation	/apps/cli/src/vault/models/cipher.response.ts: 34	Attack Vector

Fixed Issues

Severity	Issue	Source File / Package
	Client_Privacy_Violation	/apps/cli/src/commands/get.command.ts: 331

[nick-livefront]

I am not seeing TOTP codes within a free organization on the web vault or desktop for a premium user.

Screen.Recording.2025-01-10.at.2.51.29.PM.mov

[nick-livefront]

👍 Helpful comment