Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14850] Flatpak development & qa artifacts #11925

Merged
merged 3 commits into from
Nov 13, 2024
Merged

[PM-14850] Flatpak development & qa artifacts #11925

merged 3 commits into from
Nov 13, 2024

Conversation

quexten
Copy link
Contributor

@quexten quexten commented Nov 8, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14850

📔 Objective

Adds QA artifacts for flatpak, and adds npm command to pack flatpak for development.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Nov 8, 2024

Logo
Checkmarx One – Scan Summary & Detailsb781bca2-d2dc-42f4-827b-ed1b8b11a317

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1381 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 318 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 928 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1332 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 928 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1332 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1381 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 318 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 484
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 457
MEDIUM Client_Privacy_Violation /apps/desktop/src/platform/components/approve-ssh-request.html: 6
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 76
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 76
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 76
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 76
MEDIUM Client_Privacy_Violation /libs/vault/src/components/password-history-view/password-history-view.component.html: 6
MEDIUM Client_Privacy_Violation /libs/vault/src/components/password-history-view/password-history-view.component.html: 6
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 212
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 209
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 76
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 76
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 76
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 76
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 76
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 76
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 76
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 76
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 76
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 76
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 76
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 76
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 76
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 76
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 76
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 76
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/view.component.ts: 101
MEDIUM Client_Privacy_Violation

More results are available on AST platform

@quexten quexten changed the base branch from main to km/pm-14252/switch-to-oo7 November 12, 2024 12:25
@quexten quexten changed the title Km/flatpak devel [PM-14850] Flatpak development & qa artifacts Nov 12, 2024
@quexten quexten marked this pull request as ready for review November 12, 2024 13:00
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.49%. Comparing base (3508b46) to head (4f7688a).
Report is 9 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11925      +/-   ##
==========================================
+ Coverage   33.48%   33.49%   +0.01%     
==========================================
  Files        2845     2844       -1     
  Lines       89056    89024      -32     
  Branches    16983    16976       -7     
==========================================
- Hits        29817    29816       -1     
+ Misses      56899    56868      -31     
  Partials     2340     2340              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quexten quexten requested review from a team as code owners November 13, 2024 13:41
@quexten quexten requested review from coroiu, r-tome and Jingo88 November 13, 2024 13:41
@quexten quexten changed the base branch from km/pm-14252/switch-to-oo7 to main November 13, 2024 13:41
@quexten quexten removed request for a team, coroiu, Jingo88 and r-tome November 13, 2024 13:42
@trmartin4 trmartin4 requested a review from vgrassia November 13, 2024 14:48
@quexten quexten merged commit a75c211 into main Nov 13, 2024
70 checks passed
@quexten quexten deleted the km/flatpak-devel branch November 13, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants