-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-14653] Delete Unassigned Ciphers #11930
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #11930 +/- ##
==========================================
- Coverage 33.49% 33.49% -0.01%
==========================================
Files 2839 2839
Lines 88705 88706 +1
Branches 16887 16888 +1
==========================================
Hits 29715 29715
- Misses 56665 56666 +1
Partials 2325 2325 ☔ View full report in Codecov by Sentry. |
New Issues
|
🎟️ Tracking
PM-14653
📔 Objective
When a cipher is unassigned in the Admin Console it needs to be deleted with admin privileges. Without passing the admin flag, the delete request comes back as a 404 as the user does not have direct access to it.
Notes
Owners and admins can manage all collections and items
setting is disabled.📸 Screenshots
delete-unassigned-failure.mov
delete-unassigned-success.mov
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes