-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PM-15070 Star critical apps #12109
base: main
Are you sure you want to change the base?
PM-15070 Star critical apps #12109
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #12109 +/- ##
==========================================
+ Coverage 34.28% 34.31% +0.02%
==========================================
Files 2933 2935 +2
Lines 90079 90157 +78
Branches 16916 16924 +8
==========================================
+ Hits 30884 30933 +49
- Misses 56737 56765 +28
- Partials 2458 2459 +1 ☔ View full report in Codecov by Sentry. |
Great job, no security vulnerabilities found in this Pull Request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quick change of moving around some of the logic.
...den_license/bit-common/src/tools/reports/risk-insights/services/critical-apps-api.service.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I fixed the merge conflict.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-15070
📔 Objective
When a record is flagged - then show a "star" next to it rather than a checkbox
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes