Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-15070 Star critical apps #12109

Open
wants to merge 36 commits into
base: main
Choose a base branch
from

Conversation

voommen-livefront
Copy link
Collaborator

@voommen-livefront voommen-livefront commented Nov 22, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-15070

📔 Objective

When a record is flagged - then show a "star" next to it rather than a checkbox

📸 Screenshots

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@voommen-livefront voommen-livefront requested a review from a team as a code owner November 22, 2024 18:02
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 51.64835% with 44 lines in your changes missing coverage. Please review.

Project coverage is 34.31%. Comparing base (f286647) to head (313ceeb).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../access-intelligence/all-applications.component.ts 0.00% 28 Missing ⚠️
...ols/access-intelligence/risk-insights.component.ts 0.00% 5 Missing ⚠️
...isk-insights/services/critical-apps-api.service.ts 42.85% 4 Missing ⚠️
.../access-intelligence/access-intelligence.module.ts 0.00% 4 Missing ⚠️
.../src/tools/reports/risk-insights/services/index.ts 0.00% 2 Missing ⚠️
...ts/risk-insights/services/critical-apps.service.ts 97.77% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12109      +/-   ##
==========================================
+ Coverage   34.28%   34.31%   +0.02%     
==========================================
  Files        2933     2935       +2     
  Lines       90079    90157      +78     
  Branches    16916    16924       +8     
==========================================
+ Hits        30884    30933      +49     
- Misses      56737    56765      +28     
- Partials     2458     2459       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Logo
Checkmarx One – Scan Summary & Details6c7985cf-2780-4c21-a938-00aad1f52424

Great job, no security vulnerabilities found in this Pull Request

Copy link
Member

@audreyality audreyality left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ It looks like this PR has conflicts with #12005 and #12039. Please tag me back in once that PR merges.

Copy link
Contributor

@ttalty ttalty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick change of moving around some of the logic.

@ttalty ttalty requested a review from audreyality January 13, 2025 18:35
ttalty
ttalty previously approved these changes Jan 13, 2025
Copy link
Contributor

@ttalty ttalty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I fixed the merge conflict.

@voommen-livefront
Copy link
Collaborator Author

❌ It looks like this PR has conflicts with #12005 and #12039. Please tag me back in once that PR merges.

@audreyality - to make this easier, I closed #12005 and #12039 into a single PR. You had reviewed #12039 (#12039) and approved it a while ago!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants