[PM-10413] ssh keygen on web and browser

[quexten]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-10413

📔 Objective

Removes ssh-keygen from desktop native and switches over to using the sdk. Further, this adds ssh-keygen support on all clients.

📸 Screenshots

Screen.Recording.2024-11-28.at.14.29.30.mov

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – ae3284f0-553a-4c47-a09f-1d921f1fa926

Fixed Issues

Severity	Issue	Source File / Package
	Client_Privacy_Violation	/apps/browser/src/background/runtime.background.ts: 374

[codecov]

Codecov Report

Attention: Patch coverage is 28.33333% with 43 lines in your changes missing coverage. Please review.

Project coverage is 34.15%. Comparing base (3949aae) to head (4497fee).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...angular/src/vault/components/add-edit.component.ts	0.00%	21 Missing ⚠️
...ponents/sshkey-section/sshkey-section.component.ts	25.00%	15 Missing ⚠️
...ew-item-dropdown/new-item-dropdown-v2.component.ts	75.00%	0 Missing and 2 partials ⚠️
.../desktop/src/vault/app/vault/add-edit.component.ts	0.00%	2 Missing ⚠️
...access/view/emergency-add-edit-cipher.component.ts	66.66%	0 Missing and 1 partial ⚠️
...c/app/vault/individual-vault/add-edit.component.ts	66.66%	0 Missing and 1 partial ⚠️
.../web/src/app/vault/org-vault/add-edit.component.ts	66.66%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #12176   +/-   ##
=======================================
  Coverage   34.15%   34.15%           
=======================================
  Files        2936     2936           
  Lines       90192    90227   +35     
  Branches    16928    16940   +12     
=======================================
+ Hits        30807    30820   +13     
- Misses      56938    56952   +14     
- Partials     2447     2455    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Patrick-Pimentel-Bitwarden]

Looked over code and it looks like good work was done. I am a new hire so if you'd like more senior eyes on this please let me know and I'll rope in someone.

[quexten]

Resolved merge conflicts; also note: Removed the "regenerate" button, after this came up as a potential confusing point in a meeting. So ssh keys are now only generated when creating a new item.

[quexten]

Resolved merge conflicts (seems just one file got removed).

[Patrick-Pimentel-Bitwarden]

Looks good to me. 👍

[quexten]

Seems updating the base branch cause some cargo conflict, fixed now.