Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16227] Move import to sdk and enable it in browser/web #12479

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Merge branch 'main' into km/pm-16227/ssh-import-web-browser

2886cbe
Select commit
Loading
Failed to load commit list.
Open

[PM-16227] Move import to sdk and enable it in browser/web #12479

Merge branch 'main' into km/pm-16227/ssh-import-web-browser
2886cbe
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 27, 2024 in 0s

33.77% (-0.02%) compared to 395258d

View this Pull Request on Codecov

33.77% (-0.02%) compared to 395258d

Details

Codecov Report

Attention: Patch coverage is 11.11111% with 64 lines in your changes missing coverage. Please review.

Project coverage is 33.77%. Comparing base (395258d) to head (2886cbe).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...angular/src/vault/components/add-edit.component.ts 0.00% 30 Missing ⚠️
...ponents/sshkey-section/sshkey-section.component.ts 15.62% 24 Missing and 3 partials ⚠️
libs/common/src/models/export/ssh-key.export.ts 0.00% 5 Missing ⚠️
...vault/popup/components/vault/add-edit.component.ts 0.00% 1 Missing ⚠️
.../desktop/src/vault/app/vault/add-edit.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #12479      +/-   ##
==========================================
- Coverage   33.79%   33.77%   -0.02%     
==========================================
  Files        2912     2912              
  Lines       90701    90736      +35     
  Branches    17153    17162       +9     
==========================================
- Hits        30648    30646       -2     
- Misses      57667    57697      +30     
- Partials     2386     2393       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov