Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16982] Make argon2 the default kdf for new accounts #12614

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

quexten
Copy link
Contributor

@quexten quexten commented Dec 29, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16982
Server PR: bitwarden/server#5253

📔 Objective

Makes argon2, with the default settings, the default KDF for new accounts. This is behind a feature-flag.

📸 Screenshots

Screen.Recording.2025-01-13.at.11.58.50.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@quexten quexten changed the title Make argon2 the default kdf Make argon2 the default kdf for new accounts Dec 29, 2024
Copy link
Contributor

github-actions bot commented Dec 29, 2024

Logo
Checkmarx One – Scan Summary & Detailscda2034e-c140-4719-b4c4-cf6b65bbffe5

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Dec 29, 2024

Codecov Report

Attention: Patch coverage is 13.63636% with 19 lines in your changes missing coverage. Please review.

Project coverage is 34.13%. Comparing base (fe9b097) to head (ff9c6dd).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../angular/src/auth/components/register.component.ts 0.00% 7 Missing ⚠️
...angular/input-password/input-password.component.ts 0.00% 7 Missing ⚠️
libs/key-management/src/models/kdf-config.ts 33.33% 2 Missing ⚠️
apps/browser/src/auth/popup/register.component.ts 0.00% 1 Missing ⚠️
apps/desktop/src/auth/register.component.ts 0.00% 1 Missing ⚠️
libs/key-management/src/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12614      +/-   ##
==========================================
- Coverage   34.14%   34.13%   -0.01%     
==========================================
  Files        2936     2936              
  Lines       90440    90461      +21     
  Branches    16991    16998       +7     
==========================================
+ Hits        30878    30881       +3     
- Misses      57104    57121      +17     
- Partials     2458     2459       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quexten quexten marked this pull request as ready for review December 29, 2024 02:53
@quexten quexten requested review from a team as code owners December 29, 2024 02:53
@quexten quexten marked this pull request as draft December 29, 2024 02:54
@quexten quexten marked this pull request as ready for review December 29, 2024 11:37
@quexten quexten marked this pull request as draft December 29, 2024 11:41
@quexten quexten removed the request for review from JaredSnider-Bitwarden January 3, 2025 13:17
@quexten quexten removed the request for review from a team January 13, 2025 11:13
@quexten quexten changed the title Make argon2 the default kdf for new accounts [PM-16982] Make argon2 the default kdf for new accounts Jan 13, 2025
@quexten quexten marked this pull request as ready for review January 13, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant