Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-15979] restore min max attributes #12763

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

audreyality
Copy link
Member

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-15979

๐Ÿ“” Objective

Restoring the min/max attributes prevents a UI desync when the generator's autocorrection logic completes within the same change detection cycle that signals the change.

It introduces an error message flicker in Chromium browsers. This happens because the invalid value is detected and the UI updated before autocorrection occurs. Then the autocorrected value is written into the form, validation re-runs, and updates the UI to hide the error message.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@audreyality audreyality requested a review from a team as a code owner January 8, 2025 20:58

This comment was marked as resolved.

This comment was marked as resolved.

@audreyality audreyality marked this pull request as draft January 9, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant