Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] QA Test branch for biometrics fixes #12801

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

quexten
Copy link
Contributor

@quexten quexten commented Jan 10, 2025

🎟️ Tracking

#12797
https://bitwarden.atlassian.net/browse/PM-16914

#12799
https://bitwarden.atlassian.net/browse/PM-16932

#12792
https://bitwarden.atlassian.net/browse/PM-16910

#12781
https://bitwarden.atlassian.net/browse/PM-16895

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailscf39a602-670a-4710-a89a-67a3343f019d

No New Or Fixed Issues Found

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 34.13%. Comparing base (c1e3836) to head (2a4dad7).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../lock/services/extension-lock-component.service.ts 77.77% 1 Missing and 1 partial ⚠️
.../auth/popup/settings/account-security.component.ts 0.00% 1 Missing ⚠️
...pps/desktop/src/app/accounts/settings.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12801   +/-   ##
=======================================
  Coverage   34.13%   34.13%           
=======================================
  Files        2936     2936           
  Lines       90428    90434    +6     
  Branches    16988    16989    +1     
=======================================
+ Hits        30869    30873    +4     
- Misses      57102    57103    +1     
- Partials     2457     2458    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants