Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16978] Add support for fido2 2fa on mac #12823

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[PM-16978] Add support for fido2 2fa on mac #12823

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22cc9f4
Add support for fido2 2fa on mac
quexten Jan 13, 2025
814cee0
Update comment
quexten Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion apps/desktop/src/platform/services/electron-platform-utils.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,9 @@
// Temporarily restricted to only Windows until https://github.com/electron/electron/pull/28349
// has been merged and an updated electron build is available.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment should be updated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the comment. Also doesn't seem like electron will ever add support here, so I removed the reference to the PR and noted this has to be added in a different way.

supportsWebAuthn(win: Window): boolean {
return this.getDevice() === DeviceType.WindowsDesktop;
return (

Check warning on line 83 in apps/desktop/src/platform/services/electron-platform-utils.service.ts

View check run for this annotation

Codecov / codecov/patch

apps/desktop/src/platform/services/electron-platform-utils.service.ts#L83 

Added line #L83 was not covered by tests
this.getDevice() === DeviceType.WindowsDesktop || this.getDevice() === DeviceType.MacOsDesktop
);
}

supportsDuo(): boolean {
Expand Down
Loading