Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16868] Add csv export instructions for Nordpass #12829

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

djsmith85
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16868

📔 Objective

When the Nordpass was selected on the import page, no instructions for th csv export were shown. This PR adds instructions when the Nordpass csv format is selected. I must have missed this, when I implemented the importer with bitwarden/jslib#360

📸 Screenshots

Before

image

After

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@djsmith85 djsmith85 requested a review from a team as a code owner January 13, 2025 11:29
@djsmith85 djsmith85 enabled auto-merge (squash) January 13, 2025 11:29
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsb35dfd2f-3e66-4bde-a4f2-ac5fb4d4b8ea

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.13%. Comparing base (53618e8) to head (2e9b93e).
Report is 12 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12829      +/-   ##
==========================================
- Coverage   34.13%   34.13%   -0.01%     
==========================================
  Files        2936     2936              
  Lines       90439    90440       +1     
  Branches    16990    16991       +1     
==========================================
  Hits        30871    30871              
- Misses      57110    57111       +1     
  Partials     2458     2458              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djsmith85 djsmith85 merged commit ffe05f2 into main Jan 13, 2025
83 of 84 checks passed
@djsmith85 djsmith85 deleted the tools/pm-16868/add-nordpass-export-instructions branch January 13, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants