Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-14051-storybook-implementation #12840

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dan-livefront
Copy link
Collaborator

  • Initial storybook set up
  • Initial stories and folder structure

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14051

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

-Initial stories and folder structure
Copy link
Contributor

github-actions bot commented Jan 13, 2025

Logo
Checkmarx One – Scan Summary & Details8c30fe7f-6e76-4ab4-8939-5452757d1423

New Issues (1)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault-v2/vault-list-items-container/vault-list-items-container.component.html: 15
detailsMethod at line 15 of /apps/browser/src/vault/popup/components/vault-v2/vault-list-items-container/vault-list-items-container.component.html sends ...
Attack Vector
Fixed Issues (1)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM Client_Privacy_Violation /bitwarden_license/bit-web/src/app/tools/access-intelligence/org-at-risk-members-dialog.component.html: 17

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 82 lines in your changes missing coverage. Please review.

Project coverage is 34.26%. Comparing base (fb4d7e8) to head (599ae8e).
Report is 16 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../content/components/stories/icons/icons.stories.ts 0.00% 23 Missing ⚠️
...src/autofill/content/components/.storybook/main.ts 0.00% 14 Missing ⚠️
...components/stories/cipher/cipher-action.stories.ts 0.00% 7 Missing ⚠️
...t/components/stories/cipher/cipher-icon.stories.ts 0.00% 7 Missing ⚠️
...ts/stories/cipher/cipher-indicator-icon.stories.ts 0.00% 7 Missing ⚠️
...ons/action-button-stories/action-button.stories.ts 0.00% 6 Missing ⚠️
...ttons/badge-button-stories/badge-button.stories.ts 0.00% 6 Missing ⚠️
...ttons/close-button-stories/close-button.stories.ts 0.00% 6 Missing ⚠️
...buttons/edit-button-stories/edit-button.stories.ts 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12840      +/-   ##
==========================================
- Coverage   34.31%   34.26%   -0.06%     
==========================================
  Files        2930     2943      +13     
  Lines       89990    90270     +280     
  Branches    16905    16942      +37     
==========================================
+ Hits        30880    30930      +50     
- Misses      56652    56876     +224     
- Partials     2458     2464       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant