-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SM-891] Include Secrets Manager in organization license for self-hosting #3222
Conversation
No New Or Fixed Issues Found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Changes look good! Thanks for taking care of this
Type of change
Objective
The purpose of this PR is to enable Secrets Manager for self-hosting.
This requires adding Secrets Manager properties into the organization license.
Client PR bitwarden/clients#6088
Code changes
src/Api/SecretsManager/Controllers/AccessPoliciesController.cs:
src/Api/SecretsManager/Controllers/ProjectsController.cs:
src/Api/SecretsManager/Controllers/SecretsController.cs:
src/Api/SecretsManager/Controllers/SecretsManagerPortingController.cs:
src/Api/SecretsManager/Controllers/SecretsTrashController.cs:
src/Api/SecretsManager/Controllers/ServiceAccountsController.cs:
Removing self-hosted restriction from SM endpoints.
src/Core/Entities/Organization.cs:
Adding Secrets Manager properties in the
UpdateFromLicense
method.src/Core/Models/Business/OrganizationLicense.cs:
Adding Secrets Manager properties to the
OrganizationLicense
.Incrementing
CURRENT_LICENSE_FILE_VERSION
as directed in the summary.Updating
GetDataBytes
method with new version.Updating
VerifyData
method with new version. I noticed version 12 is missing from this method.src/Core/Services/Implementations/OrganizationService.cs:
Add SM properties in the
SignUpAsync
method.Before you submit
dotnet format --verify-no-changes
) (required)