Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AC-1705] Update PayPal Verification URL to point to updated domain #3338

Conversation

cyprain-okeke
Copy link
Contributor

Type of change

- [X] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

PayPal updated its IPN verification callback URL to include a subdomain https://ipnpb.sandbox.paypal.com/cgi-bin/webscr (for Sandbox IPNs) and https://ipnpb.paypal.com/cgi-bin/webscr (for live IPNs)

Code changes

  • PayPalIpnClient.cs: change the Production and sandbox url to match what is available on paypal documentation and also include User-Agent to the request header

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@cyprain-okeke cyprain-okeke requested a review from a team as a code owner October 11, 2023 18:51
@bitwarden-bot
Copy link

bitwarden-bot commented Oct 11, 2023

Logo
Checkmarx One – Scan Summary & Detailscfc8025a-ec19-409b-a915-a0c8b54e870f

New Issues

Severity Issue Source File / Package Checkmarx Insight
LOW Log_Forging /src/Billing/Controllers/PayPalController.cs: 64 Attack Vector
LOW Log_Forging /src/Billing/Controllers/PayPalController.cs: 64 Attack Vector

@cyprain-okeke cyprain-okeke requested a review from a team October 11, 2023 20:53
Hinton
Hinton previously approved these changes Oct 12, 2023
Copy link
Member

@Hinton Hinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@cturnbull-bitwarden cturnbull-bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding logging! If you wouldn't mind, please update to include some descriptive messages in the logs. I left some comments with my suggestions, but ultimately it's up to you

src/Billing/Utilities/PayPalIpnClient.cs Outdated Show resolved Hide resolved
src/Billing/Utilities/PayPalIpnClient.cs Show resolved Hide resolved
src/Billing/Utilities/PayPalIpnClient.cs Outdated Show resolved Hide resolved
Copy link
Contributor

@cturnbull-bitwarden cturnbull-bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you sir!

@bitwarden-devops-bot bitwarden-devops-bot temporarily deployed to QA Cloud October 18, 2023 15:41 Inactive
@cyprain-okeke cyprain-okeke enabled auto-merge (squash) October 18, 2023 16:05
@cyprain-okeke cyprain-okeke merged commit 95bf85d into master Oct 18, 2023
4 of 5 checks passed
@cyprain-okeke cyprain-okeke deleted the ac-1705/update-paypal-verification-url-to-point-to-updated-domain branch October 18, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants