Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add identity tests to test solution #3342

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Add identity tests to test solution #3342

merged 1 commit into from
Oct 13, 2023

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Oct 13, 2023

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

CI seems to use the test solution for running tests. Identity.Api was missing from this solution which caused the tests to be skipped during CI.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@Hinton Hinton requested a review from a team as a code owner October 13, 2023 12:06
@Hinton Hinton merged commit 27314ac into master Oct 13, 2023
21 checks passed
@Hinton Hinton deleted the ps/add-identity-test branch October 13, 2023 12:15
@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Details774b261b-4cb9-460d-91d6-db8915454b84

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants