Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC Team code ownership moves - Api project #3351

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Conversation

eliykat
Copy link
Member

@eliykat eliykat commented Oct 18, 2023

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

First pass at implementing code ownership for AC Team in the Api project. We have almost no code ownership in server at the moment, so even if this is incomplete (which it is), the idea is just to get something in place.

Notes:

  • there are quite a few Billing endpoints in the OrganizationsController. These can be split out later. I've left the request/response models for these endpoints outside our ownership.
  • I think we probably own connections/domains/maybe sponsorship. But I haven't worked with those in a while so I'm going to come back to them later. Again, this PR is just targeting low hanging fruit.

Code changes

  • file.ext: Description of what was changed and why

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@eliykat eliykat marked this pull request as ready for review October 18, 2023 04:46
@eliykat eliykat requested review from a team as code owners October 18, 2023 04:46
@eliykat eliykat requested a review from r-tome October 18, 2023 04:46
@bitwarden-bot
Copy link

bitwarden-bot commented Oct 18, 2023

Logo
Checkmarx One – Scan Summary & Details9fe765fa-4678-4b24-a1c0-e70a122e083e

No New Or Fixed Issues Found

@eliykat eliykat enabled auto-merge (squash) October 18, 2023 05:40
Copy link
Member

@jlf0dev jlf0dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@eliykat eliykat merged commit 37e9d70 into master Oct 18, 2023
41 checks passed
@eliykat eliykat deleted the ac-team-code-ownership-api branch October 18, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants