Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AC-1783] PayPal IPN Changes #3404

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Conversation

cturnbull-bitwarden
Copy link
Contributor

…ore logging

Type of change

- [X] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Currently, all PayPal IPN requests are failing. This story is to revert the changes previously added to the IPN client, and then add more logging

Code changes

  • PayPalIpnClient.cs: Reverted prior changes to the PayPal client, and added more logging

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

Copy link
Contributor

@cyprain-okeke cyprain-okeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bitwarden-bot
Copy link

bitwarden-bot commented Nov 2, 2023

Logo
Checkmarx One – Scan Summary & Details6ba06a5e-7d98-43ed-9e0d-18794d6197a6

New Issues

Severity Issue Source File / Package Checkmarx Insight
LOW Log_Forging /src/Billing/Controllers/PayPalController.cs: 64 Attack Vector

@cyprain-okeke cyprain-okeke enabled auto-merge (squash) November 2, 2023 14:22
@cyprain-okeke cyprain-okeke merged commit abc7b35 into master Nov 2, 2023
42 of 43 checks passed
@cyprain-okeke cyprain-okeke deleted the AC-1783-PayPal-IPN-Failures branch November 2, 2023 14:22
cturnbull-bitwarden added a commit that referenced this pull request Nov 2, 2023
* Reverted changes to the domain for the PayPal IPN client, and added more logging

* Removing User-Agent as it wasn't in the IPN client previously
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants