Drop LimitCollectionCreationDeletion from the database

[addisonbeck]

🎟️ Tracking

🧵 Jira Ticket: PM-10863

📚 Stacked PRs

1. server: Split LimitCollectionCreationDeletion into two database columns #4709
2. server: Split Organization.LimitCollectionCreationDeletion into two separate business rules #4730
3. clients: Split Organization.LimitCollectionCreationDeletion into two separate business rules clients#11223
4. server: Turn on LimitCollectionCreationDeletionSplit for self host #4808
5. server: [PM-14821] [PM-14822] Remove LimitCollectionCreationDeletionSplit feature flag #4809
6. clients: [PM-14821] Remove LimitCollectionCreationDeletionSplit feature flag clients#11258
7. server: Drop LimitCollectionCreationDeletion from the database #4810
   ⬆️ YOU ARE HERE

📔 Objective

🤳 The Bigger Picture

There is an option in the Admin Console that removes collection creation and
deletion controls from all organization members that are not in the Owner and
Admin roles. This PR stack splits this conjoined option into two separate
controls: one to block create operations and one to block delete
operations. This is a part of an effort to make these settings better align
with what customers expect it to do.

👉 This Pull Request 👍

This is the final pull request in this stack. This commit includes:

1. Removal of the LimitCollectionCreationDeletion database column from all
   database providers.
2. Removal of the use of LimitCollectionCreationDeletion from all MSSSQL
   views, stored procedures, etc.

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – 84b91410-bbe3-4ba1-858b-9c99ef775569

New Issues

Severity	Issue	Source File / Package	Checkmarx Insight
	Privacy_Violation	/src/Core/AdminConsole/OrganizationAuth/UpdateOrganizationAuthRequestCommand.cs: 84	Attack Vector
	Privacy_Violation	/src/Core/NotificationHub/NotificationHubPushNotificationService.cs: 195	Attack Vector
	Log_Forging	/src/Api/Tools/Controllers/SendsController.cs: 299	Attack Vector
	Log_Forging	/src/Api/Tools/Controllers/SendsController.cs: 193	Attack Vector
	Log_Forging	/src/Api/Tools/Controllers/SendsController.cs: 157	Attack Vector
	Log_Forging	/src/Api/KeyManagement/Controllers/AccountsKeyManagementController.cs: 37	Attack Vector
	Log_Forging	/src/Api/KeyManagement/Controllers/AccountsKeyManagementController.cs: 37	Attack Vector

Fixed Issues

Severity	Issue	Source File / Package
	CSRF	/src/Billing/Controllers/StripeController.cs: 164
	CSRF	/src/Billing/Controllers/RecoveryController.cs: 38
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 220
	CSRF	/src/Admin/AdminConsole/Controllers/OrganizationsController.cs: 371
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 220
	CSRF	/src/Api/AdminConsole/Controllers/GroupsController.cs: 80
	CSRF	/src/Api/AdminConsole/Controllers/GroupsController.cs: 121
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 470
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 173
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 533
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 533
	CSRF	/src/Api/AdminConsole/Controllers/GroupsController.cs: 252
	Privacy_Violation	/src/Api/Auth/Models/Request/Accounts/SetPasswordRequestModel.cs: 28
	Log_Forging	/src/Billing/Controllers/RecoveryController.cs: 38
	Log_Forging	/src/Billing/Controllers/RecoveryController.cs: 38
	Log_Forging	/src/Api/Vault/Controllers/CiphersController.cs: 173
	Log_Forging	/src/Identity/Controllers/AccountsController.cs: 144
	Log_Forging	/src/Identity/Controllers/AccountsController.cs: 144
	Log_Forging	/src/Identity/Controllers/AccountsController.cs: 144
	Log_Forging	/src/Api/Auth/Controllers/AccountsController.cs: 927
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 164
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 164
	Log_Forging	/src/Identity/Controllers/AccountsController.cs: 76
	Log_Forging	/src/Identity/Controllers/AccountsController.cs: 76
	Log_Forging	/src/Identity/Controllers/AccountsController.cs: 76
	Log_Forging	/src/Api/Auth/Controllers/AccountsController.cs: 381
	Log_Forging	/src/Api/Auth/Controllers/AccountsController.cs: 261

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.75%. Comparing base (fb72e82) to head (8f3879a).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4810      +/-   ##
==========================================
- Coverage   43.75%   43.75%   -0.01%     
==========================================
  Files        1476     1476              
  Lines       68146    68144       -2     
  Branches     6172     6172              
==========================================
- Hits        29816    29815       -1     
+ Misses      37032    37031       -1     
  Partials     1298     1298              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.