QA-689/BEEEP-public-api-GET-subscription-details

[aj-bw]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/QA-689

📔 Objective

Add a GET operation to the Organization Subscription endpoint to allow retrieving subscription details via the Public API. re organized the classes into Request and Response directories to follow patterns throughout the server project.

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 42 lines in your changes missing coverage. Please review.

Project coverage is 42.87%. Comparing base (eee7494) to head (7f6e67f).
Report is 92 commits behind head on main.

Files with missing lines	Patch %	Lines
...lling/Public/Controllers/OrganizationController.cs	0.00%	26 Missing ⚠️
...se/OrganizationSubscriptionDetailsResponseModel.cs	0.00%	16 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5041      +/-   ##
==========================================
+ Coverage   42.68%   42.87%   +0.18%     
==========================================
  Files        1411     1436      +25     
  Lines       65131    65747     +616     
  Branches     5969     6031      +62     
==========================================
+ Hits        27804    28191     +387     
- Misses      36082    36290     +208     
- Partials     1245     1266      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Checkmarx One – Scan Summary & Details – aa5aa2f2-b2e5-4f77-af78-25e7d571a5f3

New Issues

Severity	Issue	Source File / Package	Checkmarx Insight
	Log_Forging	/src/Api/Billing/Controllers/OrganizationSponsorshipsController.cs: 97	Attack Vector
	Log_Forging	/src/Api/Billing/Controllers/OrganizationSponsorshipsController.cs: 97	Attack Vector
	Log_Forging	/src/Api/Billing/Controllers/OrganizationSponsorshipsController.cs: 97	Attack Vector
	Unsafe_Use_Of_Target_blank	/src/Admin/AdminConsole/Views/Providers/Edit.cshtml: 103	Attack Vector
	Unsafe_Use_Of_Target_blank	/src/Admin/AdminConsole/Views/Providers/Edit.cshtml: 90	Attack Vector

Fixed Issues

Severity	Issue	Source File / Package
	CSRF	/src/Api/Controllers/LicensesController.cs: 44
	Heap_Inspection	/src/Core/Billing/Licenses/LicenseConstants.cs: 33
	Heap_Inspection	/src/Core/Billing/Licenses/LicenseConstants.cs: 27
	Unpinned Actions Full Length Commit SHA	/build.yml: 581
	Unpinned Actions Full Length Commit SHA	/build.yml: 547
	Unpinned Actions Full Length Commit SHA	/build.yml: 666
	Unpinned Actions Full Length Commit SHA	/build.yml: 618
	Unsafe_Use_Of_Target_blank	/src/Core/MailTemplates/Handlebars/AdminConsole/OrganizationUserRevokedForTwoFactorPolicy.html.hbs: 11
	Unsafe_Use_Of_Target_blank	/src/Core/MailTemplates/Handlebars/FamiliesForEnterprise/FamiliesForEnterpriseRemovedFromFamilyUser.html.hbs: 11

[aj-bw]

@amorask-bitwarden added a summary for the endpoint ( thanks for the feedback @nthompson-bitwarden! )
this has otherwise passed QA and ready for Merge after the additional approval!

[bitwarden-devops-bot]

Ephemeral Environment Details:
Web: https://qa-689-public-api-get-subscription-details.ee.bitwarden.pw/web
Api: https://qa-689-public-api-get-subscription-details.ee.bitwarden.pw/api