Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move Installation and Push to platform's domain folders #5085

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

addisonbeck
Copy link
Contributor

@addisonbeck addisonbeck commented Nov 26, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-11129

📔 Objective

Pull Push and Installation code into Platform's domain. This is really the first time a Platform domain has been carved out on server, so some organizational structure was established to support this as well.

Other teams: this just updates references in your code.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@addisonbeck addisonbeck changed the base branch from main to platform/addison/PM-11129/installation-activity-column November 26, 2024 00:35
@addisonbeck addisonbeck force-pushed the platform/addison/PM-11129/codeowners branch 2 times, most recently from 0517a00 to c785e42 Compare November 26, 2024 00:44
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.69%. Comparing base (4b2030d) to head (c3a3951).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5085   +/-   ##
=======================================
  Coverage   43.69%   43.69%           
=======================================
  Files        1469     1469           
  Lines       67870    67870           
  Branches     6148     6148           
=======================================
  Hits        29658    29658           
  Misses      36919    36919           
  Partials     1293     1293           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 26, 2024

Logo
Checkmarx One – Scan Summary & Detailsccb25afe-61c4-4522-a11f-c3edde41908d

Fixed Issues

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 123
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 470
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 403
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 267

@addisonbeck addisonbeck force-pushed the platform/addison/PM-11129/codeowners branch 2 times, most recently from 15200dd to a8ef312 Compare December 2, 2024 19:59
@addisonbeck addisonbeck force-pushed the platform/addison/PM-11129/installation-activity-column branch 4 times, most recently from da70cb6 to 38870b4 Compare December 2, 2024 20:34
@addisonbeck addisonbeck force-pushed the platform/addison/PM-11129/codeowners branch from a8ef312 to 56fab66 Compare December 2, 2024 20:38
@addisonbeck addisonbeck changed the title Add Installation and Push to platform's domain folders chore: move Installation and PushRelay to platform's domain folders Dec 2, 2024
@addisonbeck addisonbeck force-pushed the platform/addison/PM-11129/codeowners branch 5 times, most recently from 46a79cc to a7d904a Compare December 3, 2024 19:13
@addisonbeck addisonbeck changed the title chore: move Installation and PushRelay to platform's domain folders chore: move Installation and Push to platform's domain folders Dec 3, 2024
justindbaur
justindbaur previously approved these changes Dec 4, 2024
Copy link
Member

@justindbaur justindbaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for adding some docs even!

@addisonbeck addisonbeck force-pushed the platform/addison/PM-11129/codeowners branch from a7d904a to 75bd011 Compare December 10, 2024 17:30
Base automatically changed from platform/addison/PM-11129/installation-activity-column to main December 13, 2024 21:04
@addisonbeck addisonbeck dismissed justindbaur’s stale review December 13, 2024 21:04

The base branch was changed.

@addisonbeck addisonbeck force-pushed the platform/addison/PM-11129/codeowners branch 6 times, most recently from d8d79d7 to 6ab06c5 Compare January 3, 2025 02:48
@addisonbeck addisonbeck force-pushed the platform/addison/PM-11129/codeowners branch from 6ab06c5 to c3a3951 Compare January 3, 2025 17:02
@addisonbeck addisonbeck marked this pull request as ready for review January 3, 2025 17:41
@addisonbeck addisonbeck requested review from a team as code owners January 3, 2025 17:41
Copy link
Contributor

@tangowithfoxtrot tangowithfoxtrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Thomas-Avery Thomas-Avery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KM changes look good

Copy link
Contributor

@rkac-bw rkac-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rr-bw rr-bw requested review from ike-kottlowski and removed request for rr-bw January 4, 2025 20:48
@addisonbeck addisonbeck enabled auto-merge (squash) January 6, 2025 11:44
@addisonbeck addisonbeck merged commit cd7c4bf into main Jan 6, 2025
56 checks passed
@addisonbeck addisonbeck deleted the platform/addison/PM-11129/codeowners branch January 6, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants