-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move Installation
and Push
to platform's domain folders
#5085
Conversation
0517a00
to
c785e42
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5085 +/- ##
=======================================
Coverage 43.69% 43.69%
=======================================
Files 1469 1469
Lines 67870 67870
Branches 6148 6148
=======================================
Hits 29658 29658
Misses 36919 36919
Partials 1293 1293 ☔ View full report in Codecov by Sentry. |
Fixed Issues
|
15200dd
to
a8ef312
Compare
da70cb6
to
38870b4
Compare
a8ef312
to
56fab66
Compare
Installation
and Push
to platform's domain foldersInstallation
and PushRelay
to platform's domain folders
46a79cc
to
a7d904a
Compare
Installation
and PushRelay
to platform's domain foldersInstallation
and Push
to platform's domain folders
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for adding some docs even!
a7d904a
to
75bd011
Compare
The base branch was changed.
d8d79d7
to
6ab06c5
Compare
6ab06c5
to
c3a3951
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KM changes look good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-11129
📔 Objective
Pull
Push
andInstallation
code into Platform's domain. This is really the first time a Platform domain has been carved out on server, so some organizational structure was established to support this as well.Other teams: this just updates references in your code.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes