Repeating pattern values for BitAutoData attribute #5167

mzieniukbw · 2024-12-19T00:18:51Z

🎟️ Tracking

📔 Objective

BitAutoData attribute, where instead of providing all possibilities of values for given argument one by one, hence duplicating the attribute over and over, you provide the possible values to test in array, resulting in one attribute, called RepeatingPatternBitAutoData.

Before:

    [Theory]
    [BitAutoData(false, false, false)]
    [BitAutoData(true, false, false)]
    [BitAutoData(false, true, false)]
    [BitAutoData(true, true, false)]
    [BitAutoData(false, false, true)]
    [BitAutoData(true, false, true)]
    [BitAutoData(false, true, true)]
    public void MyTest(bool arg1, bool arg2, bool arg3)

After:

    [Theory]
    [RepeatingPatternBitAutoData([false, true], [false, true], [false, true])
    public void MyTest(bool arg1, bool arg2, bool arg3)

Other examples: testing whether string is null, empty or contains whitespace[RepeatingPatternBitAutoData([null, "", " "])

📸 Screenshots

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

codecov · 2024-12-19T00:32:48Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.74%. Comparing base (61a8726) to head (f5bd906).
Report is 25 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5167      +/-   ##
==========================================
+ Coverage   43.70%   43.74%   +0.03%     
==========================================
  Files        1472     1476       +4     
  Lines       67963    68146     +183     
  Branches     6161     6173      +12     
==========================================
+ Hits        29703    29809     +106     
- Misses      36963    37039      +76     
- Partials     1297     1298       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-12-19T00:58:02Z

Checkmarx One – Scan Summary & Details – 3923d212-e9c1-46cd-b9fb-330280f6c972

New Issues

Issue	Source File / Package	Checkmarx Insight
CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 972	Attack Vector
CSRF	/src/Api/Auth/Controllers/TwoFactorController.cs: 108	Attack Vector
CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 927	Attack Vector
CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 639	Attack Vector
CSRF	/src/Api/Controllers/DevicesController.cs: 73	Attack Vector
CSRF	/src/Api/Auth/Controllers/EmergencyAccessController.cs: 159	Attack Vector
CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 236	Attack Vector
CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 261	Attack Vector
CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 356	Attack Vector
CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 482	Attack Vector
CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 904	Attack Vector
CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 310	Attack Vector
CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 483	Attack Vector
CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 503	Attack Vector
CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 535	Attack Vector
CSRF	/src/Api/Controllers/SettingsController.cs: 36	Attack Vector
CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 163	Attack Vector
CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 381	Attack Vector
CSRF	/src/Api/Auth/Controllers/TwoFactorController.cs: 406	Attack Vector
CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 754	Attack Vector
Privacy_Violation	/src/Core/NotificationHub/NotificationHubPushNotificationService.cs: 195	Attack Vector
Privacy_Violation	/src/Core/Auth/Services/Implementations/AuthRequestService.cs: 214	Attack Vector
Log_Forging	/src/Api/Tools/Controllers/SendsController.cs: 157	Attack Vector
Log_Forging	/src/Api/Tools/Controllers/SendsController.cs: 299	Attack Vector
Log_Forging	/src/Api/Tools/Controllers/SendsController.cs: 193	Attack Vector
Log_Forging	/src/Api/KeyManagement/Controllers/AccountsKeyManagementController.cs: 37	Attack Vector
Log_Forging	/src/Api/KeyManagement/Controllers/AccountsKeyManagementController.cs: 37	Attack Vector

Fixed Issues

Severity	Issue	Source File / Package
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 972
	CSRF	/src/Api/Auth/Controllers/EmergencyAccessController.cs: 159
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 261
	CSRF	/src/Billing/Controllers/RecoveryController.cs: 38
	CSRF	/src/Billing/Controllers/StripeController.cs: 164
	CSRF	/src/Api/Auth/Controllers/TwoFactorController.cs: 406
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 639
	CSRF	/src/Api/Auth/Controllers/TwoFactorController.cs: 108
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 754
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 535
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 381
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 163
	CSRF	/src/Api/Controllers/SettingsController.cs: 36
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 236
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 503
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 483
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 310
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 927
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 904
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 482
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 356
	CSRF	/src/Api/Controllers/DevicesController.cs: 72
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 470
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 220
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 220
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 173
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 533
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 533
	CSRF	/src/Api/Platform/Push/Controllers/PushController.cs: 42
	CVE-2024-6531	Npm-bootstrap-5.3.3
	Privacy_Violation	/src/Api/Auth/Models/Request/Accounts/SetPasswordRequestModel.cs: 28
	Privacy_Violation	/src/Core/Auth/Services/Implementations/AuthRequestService.cs: 209
	Privacy_Violation	/src/Api/AdminConsole/Controllers/OrganizationAuthRequestsController.cs: 59
	Log_Forging	/src/Api/AdminConsole/Controllers/ProvidersController.cs: 72
	Log_Forging	/src/Api/Billing/Controllers/OrganizationBillingController.cs: 259
	Log_Forging	/src/Api/Billing/Controllers/OrganizationBillingController.cs: 259
	Log_Forging	/src/Api/Billing/Controllers/OrganizationBillingController.cs: 259
	Log_Forging	/src/Api/Billing/Controllers/ProviderBillingController.cs: 104
	Log_Forging	/src/Api/Billing/Controllers/ProviderBillingController.cs: 104
	Log_Forging	/src/Api/Billing/Controllers/ProviderBillingController.cs: 104
	Log_Forging	/src/Billing/Controllers/RecoveryController.cs: 38
	Log_Forging	/src/Billing/Controllers/RecoveryController.cs: 38
	Log_Forging	/src/Api/AdminConsole/Controllers/ProvidersController.cs: 72
	Log_Forging	/src/Api/AdminConsole/Controllers/ProvidersController.cs: 72
	Log_Forging	/src/Api/Auth/Controllers/EmergencyAccessController.cs: 159
	Log_Forging	/src/Api/Vault/Controllers/CiphersController.cs: 173
	Log_Forging	/src/Api/AdminConsole/Controllers/ProvidersController.cs: 72
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 164
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 164
	Log_Forging	/src/Api/Auth/Controllers/AccountsController.cs: 261

test/Common/AutoFixture/Attributes/RepeatingPatternBitAutoDataAttribute.cs

Thomas-Avery

LGTM

… array).

Repeating pattern values for BitAutoData attribute

9ab2bf5

mzieniukbw requested a review from Thomas-Avery December 19, 2024 00:20

mzieniukbw mentioned this pull request Dec 19, 2024

[PM-15084] Push global notification creation to affected clients #5079

Draft

mzieniukbw requested a review from a team December 19, 2024 00:28

Thomas-Avery reviewed Jan 6, 2025

View reviewed changes

test/Common/AutoFixture/Attributes/RepeatingPatternBitAutoDataAttribute.cs Outdated Show resolved Hide resolved

mzieniukbw added 2 commits January 7, 2025 16:37

Merge branch 'main' into repeating-pattern-bit-audo-data

f156c29

nullable enabled, added documentation

d8b2235

Thomas-Avery previously approved these changes Jan 7, 2025

View reviewed changes

mzieniukbw added 2 commits January 8, 2025 16:21

execute test method even if no repeating pattern data provided (empty…

3c43cc5

… array).

RepeatingPatternBitAutoDataAttribute unit tests

f5bd906

mzieniukbw dismissed Thomas-Avery’s stale review via f5bd906 January 8, 2025 16:26

mzieniukbw requested a review from Thomas-Avery January 8, 2025 16:27

Thomas-Avery approved these changes Jan 9, 2025

View reviewed changes

mzieniukbw merged commit 1988f14 into main Jan 9, 2025
52 of 53 checks passed

mzieniukbw deleted the repeating-pattern-bit-audo-data branch January 9, 2025 23:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Repeating pattern values for BitAutoData attribute #5167

Repeating pattern values for BitAutoData attribute #5167

mzieniukbw commented Dec 19, 2024 •

edited

Loading

codecov bot commented Dec 19, 2024 •

edited

Loading

github-actions bot commented Dec 19, 2024 •

edited

Loading

Thomas-Avery left a comment

Repeating pattern values for BitAutoData attribute #5167

Repeating pattern values for BitAutoData attribute #5167

Conversation

mzieniukbw commented Dec 19, 2024 • edited Loading

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

🦮 Reviewer guidelines

codecov bot commented Dec 19, 2024 • edited Loading

Codecov Report

github-actions bot commented Dec 19, 2024 • edited Loading

New Issues

Fixed Issues

Thomas-Avery left a comment

Choose a reason for hiding this comment

mzieniukbw commented Dec 19, 2024 •

edited

Loading

codecov bot commented Dec 19, 2024 •

edited

Loading

github-actions bot commented Dec 19, 2024 •

edited

Loading