Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14381] Add POST /tasks/bulk-create endpoint #5188

Open
wants to merge 51 commits into
base: main
Choose a base branch
from

Conversation

gbubemismith
Copy link
Member

@gbubemismith gbubemismith commented Dec 23, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14381

📔 Objective

Admin endpoint to bulk create new tasks on the Access Intelligence page. Should accept a list of CipherIdsand the TaskType.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

shane-melton and others added 30 commits December 5, 2024 17:03
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 38.29787% with 58 lines in your changes missing coverage. Please review.

Project coverage is 43.76%. Comparing base (6bad785) to head (e6c7722).

Files with missing lines Patch % Lines
...apper/Vault/Repositories/SecurityTaskRepository.cs 0.00% 17 Missing ⚠️
src/Infrastructure.Dapper/DapperHelpers.cs 0.00% 16 Missing ⚠️
...ework/Vault/Repositories/SecurityTaskRepository.cs 0.00% 16 Missing ⚠️
...rc/Api/Vault/Controllers/SecurityTaskController.cs 0.00% 8 Missing ⚠️
...els/Request/BulkCreateSecurityTasksRequestModel.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5188      +/-   ##
==========================================
- Coverage   43.77%   43.76%   -0.02%     
==========================================
  Files        1483     1485       +2     
  Lines       68527    68615      +88     
  Branches     6206     6218      +12     
==========================================
+ Hits        29996    30027      +31     
- Misses      37221    37278      +57     
  Partials     1310     1310              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 24, 2024

Logo
Checkmarx One – Scan Summary & Detailsb3e6c97a-80ba-49c9-a1f5-de719be709c0

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CSRF /src/Billing/Controllers/PayPalController.cs: 66 Attack Vector
MEDIUM Privacy_Violation /src/Core/AdminConsole/OrganizationAuth/UpdateOrganizationAuthRequestCommand.cs: 84 Attack Vector
MEDIUM Privacy_Violation /src/Core/NotificationHub/NotificationHubPushNotificationService.cs: 195 Attack Vector
MEDIUM Privacy_Violation /src/Api/Vault/Models/Request/CipherRequestModel.cs: 173 Attack Vector
MEDIUM Privacy_Violation /src/Api/Vault/Models/Request/CipherRequestModel.cs: 202 Attack Vector
LOW Log_Forging /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 527 Attack Vector
LOW Log_Forging /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 200 Attack Vector
LOW Log_Forging /src/Api/Tools/Controllers/SendsController.cs: 193 Attack Vector
LOW Log_Forging /src/Api/Tools/Controllers/SendsController.cs: 299 Attack Vector
LOW Log_Forging /src/Api/Tools/Controllers/SendsController.cs: 157 Attack Vector
LOW Log_Forging /src/Api/KeyManagement/Controllers/AccountsKeyManagementController.cs: 37 Attack Vector
LOW Log_Forging /src/Api/KeyManagement/Controllers/AccountsKeyManagementController.cs: 37 Attack Vector
LOW Log_Forging /src/Api/Vault/Controllers/CiphersController.cs: 220 Attack Vector
LOW Log_Forging /src/Api/Auth/Controllers/AuthRequestsController.cs: 87 Attack Vector
LOW Log_Forging /src/Api/Auth/Controllers/AuthRequestsController.cs: 75 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM CSRF /src/Billing/Controllers/StripeController.cs: 164
MEDIUM CSRF /src/Billing/Controllers/RecoveryController.cs: 38
MEDIUM CSRF /src/Api/NotificationCenter/Controllers/NotificationsController.cs: 67
MEDIUM CSRF /src/Api/NotificationCenter/Controllers/NotificationsController.cs: 61
MEDIUM CSRF /src/Api/Auth/Controllers/AccountsController.cs: 470
MEDIUM CSRF /src/Api/AdminConsole/Controllers/GroupsController.cs: 80
MEDIUM CSRF /src/Admin/AdminConsole/Controllers/OrganizationsController.cs: 371
MEDIUM CSRF /src/Api/AdminConsole/Controllers/GroupsController.cs: 121
MEDIUM CSRF /src/Api/AdminConsole/Controllers/GroupsController.cs: 252
MEDIUM Privacy_Violation /src/Api/Auth/Models/Request/Accounts/SetPasswordRequestModel.cs: 28
LOW Log_Forging /src/Api/AdminConsole/Controllers/ProvidersController.cs: 72
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationBillingController.cs: 259
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationBillingController.cs: 259
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationBillingController.cs: 259
LOW Log_Forging /src/Api/AdminConsole/Controllers/ProvidersController.cs: 72
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Api/AdminConsole/Controllers/ProvidersController.cs: 72
LOW Log_Forging /src/Api/AdminConsole/Controllers/ProvidersController.cs: 72
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 927
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 261

@gbubemismith gbubemismith marked this pull request as ready for review December 27, 2024 15:28
@gbubemismith gbubemismith requested review from a team as code owners December 27, 2024 15:28
@gbubemismith
Copy link
Member Author

This PR will be retargeted to main after #5039 merges.

@gbubemismith gbubemismith added the hold Hold this PR or item until later; DO NOT MERGE label Dec 27, 2024
Base automatically changed from vault/pm-14378/security-task-auth-handler to main January 9, 2025 20:14
@gbubemismith gbubemismith removed the hold Hold this PR or item until later; DO NOT MERGE label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants