Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13765] Adding Provider Type #5215

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

jrmccannon
Copy link
Contributor

@jrmccannon jrmccannon commented Jan 3, 2025

🎟️ Tracking

PM-13765

📔 Objective

When adding provider types, this response model and call stack was missed. This PR adds Provider Type to them.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

…e for The ProviderUserOrganizationDetailsViewQuery
@jrmccannon jrmccannon requested review from a team as code owners January 3, 2025 15:03
@jrmccannon jrmccannon requested a review from JimmyVo16 January 3, 2025 15:03
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.70%. Comparing base (4b2030d) to head (9c72b1a).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5215   +/-   ##
=======================================
  Coverage   43.69%   43.70%           
=======================================
  Files        1469     1469           
  Lines       67870    67873    +3     
  Branches     6148     6148           
=======================================
+ Hits        29658    29661    +3     
  Misses      36919    36919           
  Partials     1293     1293           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 3, 2025

Logo
Checkmarx One – Scan Summary & Details19d2a06a-e840-4e30-a56e-e0f17cb488b7

No New Or Fixed Issues Found

Copy link
Contributor

@rkac-bw rkac-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jrmccannon jrmccannon merged commit 217b86b into main Jan 6, 2025
57 checks passed
@jrmccannon jrmccannon deleted the jmccannon/ac/pm-13765-add-provider-type branch January 6, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants