Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-10319] - Send 2FA Email when policy enabled #5233

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

jrmccannon
Copy link
Contributor

@jrmccannon jrmccannon commented Jan 8, 2025

🎟️ Tracking

PM-10319

📔 Objective

Corrects the email being sent when enabling 2FA Policy to non-compliant users.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jrmccannon jrmccannon requested a review from a team as a code owner January 8, 2025 20:38
@jrmccannon jrmccannon requested a review from BTreston January 8, 2025 20:38
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.75%. Comparing base (92d9b88) to head (5726010).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5233   +/-   ##
=======================================
  Coverage   43.75%   43.75%           
=======================================
  Files        1476     1476           
  Lines       68146    68146           
  Branches     6172     6172           
=======================================
  Hits        29816    29816           
  Misses      37032    37032           
  Partials     1298     1298           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Logo
Checkmarx One – Scan Summary & Details589170a0-e3d4-46f4-b434-5e1adf50697b

No New Or Fixed Issues Found

@jrmccannon jrmccannon merged commit e754ae4 into main Jan 9, 2025
53 checks passed
@jrmccannon jrmccannon deleted the jmccannon/ac/pm-10319-send-two-fa-email branch January 9, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants