Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16867] Add feature flag for Blocked Domains feature #5234

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

jprusik
Copy link
Contributor

@jprusik jprusik commented Jan 8, 2025

🎟️ Tracking

PM-16867

📔 Objective

Add Blocked Domains feature flag

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.75%. Comparing base (92d9b88) to head (4637211).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5234   +/-   ##
=======================================
  Coverage   43.75%   43.75%           
=======================================
  Files        1476     1476           
  Lines       68146    68146           
  Branches     6172     6172           
=======================================
  Hits        29816    29816           
  Misses      37032    37032           
  Partials     1298     1298           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Logo
Checkmarx One – Scan Summary & Details4ed12ad7-bcef-47ef-a6aa-313fd20c75c4

No New Or Fixed Issues Found

@jprusik jprusik requested a review from a team January 8, 2025 22:15
@jprusik jprusik merged commit 6793c81 into main Jan 8, 2025
55 checks passed
@jprusik jprusik deleted the pm-16867 branch January 8, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants