Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert updates to Microsoft.Extensions dependencies from v9 #5235

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

trmartin4
Copy link
Member

@trmartin4 trmartin4 commented Jan 8, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16875

📔 Objective

We are seeing odd behavior on startup of the 2025.5.0 deployment that seems to indicate that there's problems reading from configuration. The theorized culprit is that the Microsoft.Extensions updates to v9 (or their transitive dependencies) are not playing nicely with the fact that we haven't done a full .NET v9 update.

This PR reverts those updates from #5072 and #5073.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@audreyality audreyality self-requested a review January 8, 2025 23:02
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.75%. Comparing base (90740c3) to head (80cc0fa).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5235   +/-   ##
=======================================
  Coverage   43.75%   43.75%           
=======================================
  Files        1476     1476           
  Lines       68146    68146           
  Branches     6172     6172           
=======================================
  Hits        29816    29816           
  Misses      37032    37032           
  Partials     1298     1298           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trmartin4 trmartin4 changed the title Revert updates to Microsoft dependencies from v9 Revert updates to Microsoft.Extensions dependencies from v9 Jan 8, 2025
@audreyality
Copy link
Member

👍🏻 Checked vs the last revisions for the files and it matches up!

@trmartin4 trmartin4 merged commit a638f35 into main Jan 8, 2025
56 checks passed
@trmartin4 trmartin4 deleted the revert-v9-extension-updates branch January 8, 2025 23:04
trmartin4 added a commit that referenced this pull request Jan 8, 2025
* Revert "[deps] Tools: Update Microsoft.Extensions.Configuration to v9 (#5072)"

This reverts commit cb7cbb6.

* Revert "[deps] Tools: Update Microsoft.Extensions.DependencyInjection to v9 (#5073)"

This reverts commit 0b02640.

(cherry picked from commit a638f35)
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Logo
Checkmarx One – Scan Summary & Detailse101b4a4-7f0d-408d-8a39-bcdc4862e0cd

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants