Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-10319] - Revoke Non-Compliant 2FA Users #5241

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

jrmccannon
Copy link
Contributor

@jrmccannon jrmccannon commented Jan 9, 2025

🎟️ Tracking

PM-10319

📔 Objective

This fixes a bug where all non-admin and non-owner users are revoked when 2FA is enabled. Now, users who do not have 2FA enabled will be revoked when the policy is turned on.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jrmccannon jrmccannon requested a review from a team as a code owner January 9, 2025 17:13
@jrmccannon jrmccannon requested a review from BTreston January 9, 2025 17:13
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Logo
Checkmarx One – Scan Summary & Detailsec341c21-cf20-4dcd-aece-ec0104546d3a

No New Or Fixed Issues Found

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 43.71%. Comparing base (ced4870) to head (a976cf1).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...lidators/TwoFactorAuthenticationPolicyValidator.cs 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5241      +/-   ##
==========================================
- Coverage   43.71%   43.71%   -0.01%     
==========================================
  Files        1476     1476              
  Lines       68200    68204       +4     
  Branches     6173     6174       +1     
==========================================
+ Hits        29816    29817       +1     
- Misses      37085    37087       +2     
- Partials     1299     1300       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jrmccannon jrmccannon merged commit fd195e7 into main Jan 9, 2025
53 checks passed
@jrmccannon jrmccannon deleted the jmccannon/ac/pm-10319-only-remove-nc-users branch January 9, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants