Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update checkout action for cherry pick job #5242

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

vgrassia
Copy link
Member

@vgrassia vgrassia commented Jan 9, 2025

📔 Objective

This PR updates the checkout step for the cherry pick job so that all branches and tags are checked out. This should fix the cherry pick job finding the rc or hotfix-rc branch.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vgrassia vgrassia self-assigned this Jan 9, 2025
@vgrassia vgrassia requested a review from a team as a code owner January 9, 2025 17:19
@vgrassia vgrassia requested a review from dani-garcia January 9, 2025 17:19
@vgrassia vgrassia enabled auto-merge (squash) January 9, 2025 17:21
@vgrassia vgrassia merged commit 28d5535 into main Jan 9, 2025
51 checks passed
@vgrassia vgrassia deleted the fix-repository-management-workflow branch January 9, 2025 17:33
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Logo
Checkmarx One – Scan Summary & Details50232c16-c58f-4393-8ba9-6fc86ad5b631

No New Or Fixed Issues Found

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.71%. Comparing base (9c6ad87) to head (2b78f20).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5242   +/-   ##
=======================================
  Coverage   43.71%   43.71%           
=======================================
  Files        1476     1476           
  Lines       68200    68200           
  Branches     6173     6173           
=======================================
  Hits        29816    29816           
  Misses      37085    37085           
  Partials     1299     1299           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants