Merge pull request #2 from bkardell/master

various tweaks based on review comments
bkardell · Aug 1, 2019 · 6d77311 · 6d77311
2 parents 0d37523 + 178a8ee
commit 6d77311
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 8 deletions.
diff --git a/mathml/relations/html5-tree/css-inline-style-interface.tentative.html b/mathml/relations/html5-tree/css-inline-style-interface.tentative.html
@@ -18,21 +18,32 @@
   </head>
   <body>
     <span>This tests the presence and functionality of features of the `ElementCSSInlineStyle` interface for MathMLElements</span>
-    <math>
-      <mi>E</mi>
-    </math>
+    <math></math>
   </body>
   <script>
 
     let mathEl = document.querySelector("math");
 
+    test(function() {
+      mathEl.style.backgroundColor = "green"
+        assert_equals(
+          getComputedStyle(mathEl).backgroundColor,
+          "rgb(0, 255, 0)",
+          "The applied background should be green."
+        );
+      }, `The <math> element style property should be present and be functional.`);
+
+
+
     Object.keys(MathMLFragments).forEach((elName) => {
       mathEl.innerHTML = MathMLFragments[elName]
-      mathEl.style.backgroundColor = "green"
-      mathEl.style.display = "block"
+
       test(function() {
         let el = mathEl.firstElementChild
-        el.style.backgroundColor = "blue";
+        el.style.backgroundColor = "blue"
+
+        // guarantee that it isn't display: none somehow
+        el.style.display = "block"
         assert_equals(
           getComputedStyle(el).backgroundColor,
           "rgb(0, 0, 255)",

diff --git a/mathml/relations/html5-tree/html-or-foreign-element-interfaces.tentative.html b/mathml/relations/html5-tree/html-or-foreign-element-interfaces.tentative.html
@@ -74,8 +74,7 @@
     test(function() {
       assert_equals(
         mathEl.tabIndex,
-        -1,
-        "MathML elements should have a tabIndex property"
+        -1
       );
     }, "MathML elements should have a tabIndex property");