highcharts/15-heatmap-hsv #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawellysy
suggested changes
Dec 23, 2022
| return `#${f(0)}${f(8)}${f(4)}`; | ||
| } | ||
|
|
||
| function createHeatmapData(choice = 'none', sliderValue) { |
There was a problem hiding this comment.
Regular parameters should not come after optional parameters
There was a problem hiding this comment.
You're right, I changed it.
| const arr = []; | ||
|
|
||
| const createColor = { | ||
| 'none': (x, y) => hslToHex(x, y, 0.5), |
There was a problem hiding this comment.
instead of handling the additional case with none selection, you can assume that the first option selected is Saturation because this is what you assume nevertheless.
There was a problem hiding this comment.
I deleted the 'none' option, but I think the default case is 'value' (by default, in the beginning, saturation is on the y-axis so a number needs to be set for the value parameter [I set it to 0.5]).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created first version of the solution.