Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

highcharts-stock/1-live-data-tools #19

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jszuminski
Copy link
Collaborator

Created first version of the solution.

@jszuminski jszuminski self-assigned this Dec 28, 2022
Copy link

@pawellysy pawellysy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You got the idea right, good job!
Few comments tho.

highcharts-api/highcharts-stock/1-live-data-tools/main.js Outdated Show resolved Hide resolved
highcharts-api/highcharts-stock/1-live-data-tools/main.js Outdated Show resolved Hide resolved
highcharts-api/highcharts-stock/1-live-data-tools/main.js Outdated Show resolved Hide resolved
@jszuminski jszuminski requested a review from pawellysy January 2, 2023 08:28
Copy link

@pawellysy pawellysy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments

highcharts-api/highcharts-stock/1-live-data-tools/main.js Outdated Show resolved Hide resolved
highcharts-api/highcharts-stock/1-live-data-tools/main.js Outdated Show resolved Hide resolved
highcharts-api/highcharts-stock/1-live-data-tools/main.js Outdated Show resolved Hide resolved
Copy link

@pawellysy pawellysy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments

@jszuminski jszuminski requested a review from pawellysy January 3, 2023 07:52
Copy link

@pawellysy pawellysy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants