highcharts/3-stacked-bar #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfilipiec
suggested changes
Dec 8, 2022
Comment on lines
19
to
23
| chart.buttons = Array.from({ length: chart.yAxis[0].series.length }, () => 0); | ||
| chart.yAxis[0].series.forEach((_, ind) => { | ||
| chart.buttons[ind] = chart.renderer.button('How to fix', chart.plotWidth, chart.plotTop + axisHeight * (ind * 4 + 1) / 4, | ||
| () => console.log('Button clicked!')).add(); | ||
| }); |
There was a problem hiding this comment.
Wouldn't it be possible to assign buttons to category objects? And try using forEach to refer to them using the first parameter instead of the index, I think it would be clearer and it would take less code. What catches my eye is the _ in forEach((_, ind)
mfilipiec
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created chart (first attempt)