Repository navigation
fix: disable LFS for disabled repos - #44
Merged
Merged
Conversation
Disabled repositories should not run repository integrations. Omit the LFS underlay while preserving system and user hooks, and restore it when the repository is re-enabled.
Git exports repository-local environment variables to hooks, which can override an explicit -C target. Clear those variables so lhm and its tests always operate on the requested repository.
alecthomas
marked this pull request as ready for review
September 22, 2026 23:56
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disabled repositories currently continue to run the git-lfs underlay even though their other repository-specific hooks are suppressed. This makes
lhm disableincomplete for repositories that use LFS.This change omits underlay integrations from both dry-run config resolution and actual hook execution while preserving system and user hooks. Re-enabling the repository restores the LFS integration. End-to-end coverage verifies both execution paths and the enable transition.
The pre-push suite also exposed that Git hook environment variables could override explicit repository targets. Repository-scoped Git commands now clear those variables before applying
-C, which keeps runtime lookups and temporary-repository tests isolated.Verified by the pre-push lint and full test hooks.